Cluster: Assign default human-readable node name when starting server #2777
+35
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, servers in a cluster don't have a human-readable nodename unless explicitly set by user. This can be annoying when reading the server logs during local development, since we would need to manually lookup the unique node ID (40 chars long) to figure out its port number. Most logging statements in the cluster are in the form of
serverLog(LL_NOTICE, "Something.. %.40s (%s) something..", node->name, node->human_nodename);, and thus this would always result in an empty()like the following:Assigning a default human-readable nodename solves the annoyance:
For now I use the node's IP and port combination as the nodename. If users have personal preference on the format, they can always update nodename via
CONFIG SET cluster-announce-human-nodename MYNAMEcommand or edit the config file.