Add support for Atomic Slot Migration to CLI #2755
Open
+585
−238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option
--cluster-use-atomic-slot-migration. This will apply to both--cluster reshardand--cluster rebalancecommands.We could do some more optimizations here, but for now we batch all the slot ranges for one (source, target) pair and send them off as one
CLUSTER MIGRATESLOTSrequest. We then wait for this request to finish through pollingCLUSTER GETSLOTMIGRATIONSonce every 100ms. We parseCLUSTER GETSLOTMIGRATIONSand look for the most recent migration affecting the requested slot range, then check if it is in progress, failed, cancelled, or successful. If there is a failure or cancellation, we give this error to the user.Fixes #2504