Skip to content

Conversation

@rjd15372
Copy link
Member

@rjd15372 rjd15372 commented Oct 15, 2025

This commit adds a new INFO section called "Scripting Engines" that shows the information of the current scripting engines available in the server.

Here's an output example:

> info scriptingengines
# Scripting Engines
engines_count:2
engines_total_used_memory:68608
engines_total_memory_overhead:56
engine_0:name=LUA,module=built-in,abi_version=4,used_memory=68608,memory_overhead=16
engine_1:name=HELLO,module=helloengine,abi_version=4,used_memory=0,memory_overhead=40

This commit adds a new `INFO` section called "Scripting Engines" that
shows the information of the current scripting engines available in the
server.

Here's an output example:

```
> info scriptingengines
engines_count:2
engines_total_used_memory:68608
engines_total_memory_overhead:24
engine_0:name=HELLO,module=helloengine,abi_version=2,used_memory=0,memory_overhead=8
engine_1:name=LUA,module=built-in,abi_version=0,used_memory=68608,memory_overhead=16
```

Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
@rjd15372 rjd15372 moved this to In Progress in Valkey 9.1 Oct 15, 2025
@rjd15372 rjd15372 added the release-notes This issue should get a line item in the release notes label Oct 15, 2025
Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
@rjd15372 rjd15372 force-pushed the scripting-engine-info branch from 816841f to 14aead3 Compare October 15, 2025 12:02
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.53%. Comparing base (7043c0f) to head (7466f0c).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2738      +/-   ##
============================================
+ Coverage     72.49%   72.53%   +0.03%     
============================================
  Files           128      128              
  Lines         71624    71647      +23     
============================================
+ Hits          51927    51966      +39     
+ Misses        19697    19681      -16     
Files with missing lines Coverage Δ
src/scripting_engine.c 54.10% <100.00%> (+0.50%) ⬆️
src/server.c 88.50% <100.00%> (+0.06%) ⬆️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zuiderkwast
Copy link
Contributor

@valkey-io/core-team Please approve or share your thoughts before it gets merged...

Copy link
Member

@enjoy-binbin enjoy-binbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new info fields LGTM.

though the scriptingengines name is quite long...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes This issue should get a line item in the release notes

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants