-
Notifications
You must be signed in to change notification settings - Fork 932
Changes and fixes for the new DELIFEQ command #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DELIFEQ was added in valkey-io#1975 but had some issues. Do some refactoring to reduce the number of lines of code, write commands need to increment dirty and we can propagate it as DEL command. Signed-off-by: Binbin <binloveplay1314@qq.com>
enjoy-binbin
commented
May 22, 2025
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2120 +/- ##
============================================
- Coverage 71.19% 71.05% -0.14%
============================================
Files 122 122
Lines 66046 66045 -1
============================================
- Hits 47020 46930 -90
- Misses 19026 19115 +89
🚀 New features to boost your workflow:
|
zuiderkwast
approved these changes
May 22, 2025
Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
hwware
approved these changes
May 23, 2025
shanwan1
pushed a commit
to shanwan1/valkey
that referenced
this pull request
Jun 13, 2025
DELIFEQ was added in valkey-io#1975 but had some issues. Do some refactoring to reduce the number of lines of code, write commands need to increment dirty and we can propagate it as DEL command. Changes: 1. Replicate as DEL is important for compatibility with replicas running an older Valkey version, also it can save the compare logic, like other commands like GETDEL. 2. Signal modified key is for WATCH and do invalidate client-side caching (client tracking) 3. Keyspace notifications. 4. Dirty++ indicates there are unsaved changes for RDB. 5. Using shared strings for the RESP zero and one replies for the code cleanup. 6. Add FAST command flag and remove the ACCESS key specs flag. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: shanwan1 <shanwan1@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DELIFEQ was added in #1975 but had some issues.
Do some refactoring to reduce the number of lines of code,
write commands need to increment dirty and we can propagate
it as DEL command.
Changes:
running an older Valkey version, also it can save the compare
logic, like other commands like GETDEL.
caching (client tracking)
code cleanup.