Command types #5
Conversation
| try await resp3Upgrade(outbound: outbound, inboundIterator: &inboundIterator) | ||
| } | ||
| for await (request, continuation) in requestStream { | ||
| do { |
There was a problem hiding this comment.
This shows quite nicely that working with subscriptions at the same time can get weird... we don't want to wait for a write in order to read.
There was a problem hiding this comment.
I guess in this situation a subscription will change the state of the pipeline. And turn into a loop returning the published content. The difficulty is in RESP3 where you can continue to send commands.
There was a problem hiding this comment.
Not sure I follow you here. Sure we can add another case for subscriptions. Problem is we might not consume those if we are stuck in writing.
| public static func clusterSlaves(nodeId: String) -> RESPCommand { | ||
| RESPCommand("CLUSTER", "SLAVES", nodeId) | ||
| /// Returns the mapping of cluster slots to shards. | ||
| public struct CLUSTERSHARDS: RedisCommand { |
There was a problem hiding this comment.
Have you considered using namespaces here? So that we get CLUSTER.SHARDS?
There was a problem hiding this comment.
Will be a little more complex but should be easy enough
| RESPCommand("CLUSTER", "SLAVES", nodeId) | ||
| /// Returns the mapping of cluster slots to shards. | ||
| public struct CLUSTERSHARDS: RedisCommand { | ||
| public typealias Response = [RESPToken] |
There was a problem hiding this comment.
Can we autogen the responses here as well?
There was a problem hiding this comment.
The resp3_replies.json file is a bit shit. It does not define responses particularly well. The text for this one is
"[Array reply](/docs/reference/protocol-spec#arrays): a nested list of [Map reply](/docs/reference/protocol-spec#maps) of hash ranges and shard nodes describing individual shards."
I was thinking of adding in some way to patch the responses, as some of them end up being quite complex.
Makes the assumption the map key is always a string
adam-fowler
force-pushed
the
redis-command
branch
from
9dfabf3 to
47b9ed8
Compare
* Command types * fix hello 3 command * writeToRESPBuffer -> encode * Add support for returning maps Makes the assumption the map key is always a string * Enum namespaces for containers * Catch more response arrays in replies * Parameter pack return from pipeline * Update README * Make sure we parse all responses from pipelined requests
* Command types * fix hello 3 command * writeToRESPBuffer -> encode * Add support for returning maps Makes the assumption the map key is always a string * Enum namespaces for containers * Catch more response arrays in replies * Parameter pack return from pipeline * Update README * Make sure we parse all responses from pipelined requests
3 participants
@fabianfett @Joannis
As discussed on Discord