Testing benchmark CI improvements #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2025-04-18T10:26:49+00:00 |
|
After years of trial and error I have something working |
adam-fowler
added a commit
that referenced
this pull request
Jul 11, 2025
* Add benchmark with improvement * Look at exit status of benchmark step * See exit status, add section for significant differences * Add performance regression * print result even when successful * trying to get a regression * Increase malllocs * Change benchmark comment * minor edits * Try using set +e instead of continue-on-errors * Remove performance differences * Check improved * Report benchmark differences, don't return error * Revert temporary changes * Parse error message instead of return code * Test improvement * Fix cut * one more time * Add echo -e * Moving stuff * Redirect stderr to separate variable * another redirect attempt * Run baseline check twice * with output * Disable benchmarking to speed up check * Run benchmarks * Test no improvement * Test regression * Try with continue-on-error * Revert ValkeyBenchmarks changes * Move ci.yml back in workflows * Exit env.exitStatus
adam-fowler
added a commit
that referenced
this pull request
Jul 14, 2025
* Add benchmark with improvement * Look at exit status of benchmark step * See exit status, add section for significant differences * Add performance regression * print result even when successful * trying to get a regression * Increase malllocs * Change benchmark comment * minor edits * Try using set +e instead of continue-on-errors * Remove performance differences * Check improved * Report benchmark differences, don't return error * Revert temporary changes * Parse error message instead of return code * Test improvement * Fix cut * one more time * Add echo -e * Moving stuff * Redirect stderr to separate variable * another redirect attempt * Run baseline check twice * with output * Disable benchmarking to speed up check * Run benchmarks * Test no improvement * Test regression * Try with continue-on-error * Revert ValkeyBenchmarks changes * Move ci.yml back in workflows * Exit env.exitStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked