Skip to content

Conversation

NeedleInAJayStack
Copy link
Contributor

@NeedleInAJayStack NeedleInAJayStack commented Oct 14, 2025

This resolves a compiler crasher on open-source 6.1 and 6.2 toolchains on MacOS. There was apparently some resolution problem with some Collection<NodeAndCommands> that was fixed by making the type concrete [ValkeyServerAddress: NodeAndCommands].Values. This function is internal and only used in one call site, which required no changes.

Closes #250

Signed-off-by: Jay Herron <NeedleInAJayStack@protonmail.com>
Copy link
Collaborator

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess I don't need the some Collection here given it is an internal function

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@40c2ad0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
Sources/Valkey/Cluster/ValkeyClusterClient.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage        ?   40.92%           
=======================================
  Files           ?       94           
  Lines           ?    15785           
  Branches        ?        0           
=======================================
  Hits            ?     6460           
  Misses          ?     9325           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-fowler adam-fowler merged commit 19cd708 into valkey-io:main Oct 15, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation failures on MacOS on open-source 6.1 & 6.2 toolchains

3 participants