Throw error when command returns an error #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
error-handling
branch
from
c981b6c to
27f7dbe
Compare
fabianfett
reviewed
Apr 6, 2025
Comment on lines
+175
to
+184
| func testCommandError() async throws { | ||
| var logger = Logger(label: "Valkey") | ||
| logger.logLevel = .debug | ||
| try await ValkeyClient(.hostname(valkeyHostname, port: 6379), logger: logger).withConnection(logger: logger) { connection in | ||
| try await withKey(connection: connection) { key in | ||
| _ = try await connection.set(key: key, value: "Hello") | ||
| await #expect(throws: ValkeyClientError.self) { _ = try await connection.rpop(key: key) } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you maybe want to add this as a unit test for both RESP variants?
fabianfett
approved these changes
Apr 6, 2025
adam-fowler
force-pushed
the
error-handling
branch
from
27f7dbe to
f258fbf
Compare
adam-fowler
added a commit
that referenced
this pull request
Jul 11, 2025
adam-fowler
added a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.