added tests for testing full ingestion cycle metadata handling #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 23, 2025 17:32
Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
I, Nivesh Tuwani <tuwanivu@amazon.com>, hereby add my Signed-off-by to this commit: 8efa09f Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com> Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
BCathcart
reviewed
Oct 2, 2025
| # Comprehensive test: Create index with multiple field types for both tokenization and metadata validation | ||
| comprehensive_index = "comprehensive_test_idx" | ||
|
|
||
| # Create index with multiple field types |
There was a problem hiding this comment.
"with multiple text fields"
| "SCHEMA", "title", "TEXT", "content", "TEXT", "score", "NUMERIC" | ||
| ) == b"OK" | ||
|
|
||
| # Insert test data that covers both tokenization and metadata validation |
There was a problem hiding this comment.
Is the data relevant to metadata validation in any way?
|
|
||
| # Validate index is removed from list | ||
| import time | ||
| time.sleep(0.5) # Brief wait for cleanup |
There was a problem hiding this comment.
We should wait for a condition rather than sleep
| "Index with name 'index123' not found", | ||
| ) | ||
|
|
||
| def test_error_handling_metadata_validation(self): |
There was a problem hiding this comment.
Didn't we talk about removing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are for testing metadata handling in full ingestion cylce accross a cluster