-
Notifications
You must be signed in to change notification settings - Fork 46
Cluster metadata Validation #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
1cdba39
to
5a14aa5
Compare
I, Nivesh Tuwani <tuwanivu@amazon.com>, hereby add my Signed-off-by to this commit: 8efa09f Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com> Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
b514763
to
cd78d8c
Compare
I'm going to push back a bit on the amount of tests and whether they all belong in the same file again. First off, I'm not sure Next it looks like
|
Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
298e418
to
9f49bde
Compare
…os that would be used in later integration tests along with this one Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
bae8288
to
b9b0528
Compare
Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
8887bae
to
5688ca2
Compare
Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Let's meet tomorrow afternoon and clean up these last few small things.
node = self.new_client_for_primary(i) | ||
result = node.execute_command("FT._LIST") | ||
results.append(result) | ||
return results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add get_ft_list()
to IndexingTestHelper
and then get_ft_list_from_all_nodes
and get_ft_info_from_all_nodes
aren't really needed
Signed-off-by: Nivesh Tuwani <tuwanivu@amazon.com>
a4ca518
to
3cfc3ba
Compare
We validate wether the metadata has been propogated accross the cluster properly. We check the consistency accross different nodes in a cluster to see if everything is properly migrated.
This PR also has some changes related to #395 -> this is going to be merged into main and then in to fulltext but would be a blocking change hence added those same changes in this PR so that the testing can be comprehensive.