Update libvalkey #34
Merged
Update libvalkey #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the libvalkey library integration by adding necessary source files and dependencies. The changes include adding the "conn" source file to the build process, including the sds.h header file for string handling, and updating the include paths to support building from source.
- Adds "conn" source file to libvalkey build sources
- Includes sds.h header dependency in pack.c
- Updates include directories to support internal libvalkey dependencies
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/pack.c | Adds sds.h include for string handling functionality |
| setup.py | Adds "conn" source, reformats arrays, and includes vendor/libvalkey/src directory |
bogdanp05
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.