fix: handle non-existant redis node gracefully #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug introduced in #5 causes iovalkey to throw asynchronously from time to time and crash the instance
Before this change, if the affected methods could not find a node, they would return
undefined
; however, after the change, they immediately try to access theredis
property even if the node doesn't exist at that time, which might happen for a variety of reasonsThis is highly problematic as iovalkey runs timeout-based code periodically, and by their nature, it's very hard to catch them
Here's an example of the exception that will crash the instance: