refactor!: replace abbr SVG with <div> element #9330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
refactor_replace-abbr-svg-with-div
branch
4 times, most recently
from
ee4c445 to
ae6bc64
Compare
vursen
force-pushed
the
refactor_replace-abbr-svg-with-div
branch
7 times, most recently
from
98edddc to
d1e0e1b
Compare
vursen
force-pushed
the
refactor_replace-abbr-svg-with-div
branch
from
d1e0e1b to
b1ec14e
Compare
|
vursen
commented
May 29, 2025
| } | ||
|
|
||
| :host([theme~='xlarge']) [part='abbr'] { | ||
| font-size: 2.5em; |
There was a problem hiding this comment.
note: These values were originally calculated with SVG scaling in mind, so they are no longer valid. However, I was able to achieve a relatively close result using font-size: round(up, var(--_avatar-size) * 0.4, 3px) @jouni let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the avatar's abbr SVG with a
<div>element, following up on #9316, which made the same change for the icon SVG.This also fixes the issue of abbr rendering with the wrong color in the new base styles:
Warning
This change may be breaking, as
font-sizeon[part=abbr]now behaves differently due to removal of SVG scaling.Type of change