-
Notifications
You must be signed in to change notification settings - Fork 0
Adding the releases-graph app #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
const { expect} = require('@playwright/test'); | ||
const {log, args, createPage, closePage, takeScreenshot, waitForServerReady} = require('./test-utils'); | ||
|
||
(async () => { | ||
const arg = args(); | ||
|
||
const page = await createPage(arg.headless, arg.ignoreHTTPSErrors); | ||
|
||
await waitForServerReady(page, arg.url); | ||
|
||
await page.locator('html').first().innerHTML(); | ||
await takeScreenshot(page, __filename, 'view1-loaded'); | ||
await expect(page.getByText('Pre-releases per version').first()).toBeVisible(); | ||
|
||
await page.getByText('by release count').click(); | ||
|
||
await takeScreenshot(page, __filename, 'view3-loaded'); | ||
await expect(page.getByText('Releases per version').first()).toBeVisible(); | ||
|
||
if (arg.version && arg.version !== 'current') { | ||
const [major, minor] = arg.version.split('.'); | ||
const labelRegex = new RegExp(`${major}\\.${minor}, `); | ||
await page.getByLabel(labelRegex).click(); | ||
await expect(page.getByLabel('Interactive chart').locator('text').getByText(arg.version)).toBeVisible(); | ||
|
||
await page.getByText(arg.version).first().click(); | ||
await expect(page.getByRole('heading', { name: `Release Notes for ${arg.version}` })).toBeVisible(); | ||
} | ||
|
||
log(JSON.stringify(arg)); | ||
await closePage(page); | ||
})(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could probably add tests for the two time span graphs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not testing the app here, the app has it's own IT, probably that part might be improved because coverage is not complete, it was taken from the ui-test-generator AI output.
In pit normally we do tests that demonstrate that migrating the app to a new version it seems working.