testsuite: add feature to run health check tool #10179
Conversation
|
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10179/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
github-actions
bot
added
secondary-features
ci-pipelines
testing
ruby_rubocop
test-framework
labels
testsuite/features/secondary/srv_health_check_supportconfig.feature
Outdated
Show resolved
Hide resolved
m-czernek
changed the title
|
Note: This tests cannot run on Github, because we can't take a supportconfig from the GH Uyuni deployment. Not sure why the tests are executing even when we use the |
| When I run "curl localhost:3000/api/health -o /dev/null" on "localhost" with timeout at most 10 seconds | ||
|
|
||
| Scenario: Health Check containers are healthy and running | ||
| When I run "curl -s localhost:9000 -o /dev/null" on "localhost" |
There was a problem hiding this comment.
What about using this step?
And I wait until port "9000" is listening on "localhost" host
| And I run "curl -s localhost:3000 -o /dev/null" on "localhost" | ||
|
|
||
| Scenario: Health Check containers are exposing metrics | ||
| When I run "curl -s localhost:9000/metrics.json | python3 -c 'import sys, json; print(json.load(sys.stdin).keys())'" on "localhost" |
There was a problem hiding this comment.
Let's build a step definition for this please.
Then I check the health check tool metrics are exposed in "localhost"
| Then I obtain and extract the supportconfig from the server | ||
|
|
||
| Scenario: Execute health check tool with server supportconfig | ||
| When I run "mgr-health-check -v -s /root/server-supportconfig/uyuni-server-supportconfig/ start" on "localhost" |
There was a problem hiding this comment.
When I start health check tool with support config "/root/server-supportconfig/uyuni-server-supportconfig/" on "localhost"
|
|
||
| Scenario: Execute health check tool with server supportconfig | ||
| When I run "mgr-health-check -v -s /root/server-supportconfig/uyuni-server-supportconfig/ start" on "localhost" | ||
| Then I run "test $(podman ps | grep health-check | wc -l) == 4" on "localhost" |
There was a problem hiding this comment.
Then I check that Health check tool container is running
| When I run "curl -s localhost:9000/metrics.json | python3 -c 'import sys, json; print(json.load(sys.stdin).keys())'" on "localhost" | ||
|
|
||
| Scenario: Cleanup: Remove health check tool | ||
| When I run "mgr-health-check stop" on "localhost" |
There was a problem hiding this comment.
Same, let's build some step for this
What does this PR change?
This PR adds a new testsuite feature to run health check tool against a generated supportconfig.
It does some minimal checks to verify that health check is working properly and extracting metrics from the supportconfig as expected.
Related PRs: uyuni-project/sumaform#1829
Testing
This PR is now deployed at
suma-test-ion-controller. To test:suma-test-ion-controllercd ~/spacewalk/testsuiteGUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
Cucumber tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24380
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!