Skip to content

RFC for Kernel Templates #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Jul 30, 2025
Merged

RFC for Kernel Templates #2301

merged 46 commits into from
Jul 30, 2025
+466 −0

Conversation

dmitriy-sobolev
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev commented Jun 7, 2025 •
edited
Loading

The RFC describes the structure and common design of kernel templates. It also lists design gaps and potential improvements.

RFCs for the individual kernel templates will be added separately.

@dmitriy-sobolev dmitriy-sobolev added this to the 2022.10.0 milestone Jun 7, 2025
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/kt-base-rfc branch from 388b879 to cd3b3c6 Compare June 7, 2025 17:08
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/kt-base-rfc branch 2 times, most recently from aa93d49 to ddedf8e Compare June 9, 2025 13:21
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/kt-base-rfc branch from ddedf8e to cbd992c Compare June 9, 2025 13:24
SergeyKopienko
SergeyKopienko previously approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@SergeyKopienko SergeyKopienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/kt-base-rfc branch from dc4426d to 7e2850c Compare June 12, 2025 13:20
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/kt-base-rfc branch from 1d7ecad to 5979e34 Compare June 12, 2025 17:25
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/kt-base-rfc branch from 34e6709 to f93e4a6 Compare July 15, 2025 16:23
@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/kt-base-rfc branch from f93e4a6 to 47247af Compare July 15, 2025 16:32
akukanov
akukanov previously approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@akukanov akukanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is a good description of the KT approach as well as various questions & concerns.

danhoeflinger
danhoeflinger reviewed Jul 23, 2025
View reviewed changes
danhoeflinger
danhoeflinger previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, we discussed offline another optional potential open question about flavors of API to support (iterator, buffer, range, etc.). If you choose to add that, I can reapprove.

mmichel11
mmichel11 reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@mmichel11 mmichel11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my latest read through, I have just one question about a potential new open. I am curious to hear your thoughts.

Otherwise, everything LGTM!

@dmitriy-sobolev
Copy link
Contributor Author

dmitriy-sobolev commented Jul 24, 2025 •
edited
Loading

LGTM now, we discussed offline another optional potential open question about flavors of API to support (iterator, buffer, range, etc.). If you choose to add that, I can reapprove.

I've added it in 51517f1 + 9f42f96 as a correction.

akukanov
akukanov previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@akukanov akukanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved after reviewing the recent additions.

danhoeflinger
danhoeflinger previously approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after additions

@dmitriy-sobolev dmitriy-sobolev force-pushed the dev/dmitriy-sobolev/kt-base-rfc branch from 1e40841 to d5b12c1 Compare July 25, 2025 17:33
mmichel11
mmichel11 reviewed Jul 28, 2025
View reviewed changes
@dmitriy-sobolev @mmichel11
Suggestion: fix a typo
9c3c7c7 
Co-authored-by: Matthew Michel <106704043+mmichel11@users.noreply.github.com>
mmichel11
mmichel11 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest state LGTM

danhoeflinger
danhoeflinger approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapproving

@dmitriy-sobolev dmitriy-sobolev merged commit 5df84f7 into main Jul 30, 2025
2 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/kt-base-rfc branch July 30, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKopienko SergeyKopienko SergeyKopienko left review comments

@mmichel11 mmichel11 mmichel11 approved these changes

@danhoeflinger danhoeflinger danhoeflinger approved these changes

@adamfidel adamfidel Awaiting requested review from adamfidel

@akukanov akukanov Awaiting requested review from akukanov

Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
2022.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dmitriy-sobolev @akukanov @SergeyKopienko @mmichel11 @danhoeflinger