xe: make includes of gemmstone headers path-agnostic #4231
Conversation
|
make test |
|
|
||
| #include "common/utils.hpp" | ||
| #include "gpu/intel/gemm/jit/generator/pieces/copy_plan.hpp" | ||
| #include "gemmstone/../../generator/pieces/copy_plan.hpp" |
There was a problem hiding this comment.
How much work would it be to move the necessary interfaces from copy_plan.hpp into the external headers? Relying on the internal headers like this is not a good design choice.
There was a problem hiding this comment.
I think @atkassen can comment better. Yes, without a proper interface this is not aligned with the current design.
There was a problem hiding this comment.
If we're happy with #include "gemmstone/generator.hpp" instead, I think it should suffice:
There was a problem hiding this comment.
Yeah, looks like this just snowballs, so we can leave it as is. This definitely needs reworked at some point, gemmstone/generator.hpp shouldn't have includes outside of the include directory either.
|
make test |
4 participants
This is to allow using a standalone (or third-party) gemmstone repository for building.