GNUMakefile: fix compilation on Macs #7964
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinburke
force-pushed
the
no-selinux-mac
branch
from
de98dff to
ec94710
Compare
Previously, attempting to compile on Macs would bring in the SELinux dependencies (runcon) which led to compilation errors on Macs. Fixes uutils#7695.
kevinburke
force-pushed
the
no-selinux-mac
branch
from
ec94710 to
ec95e76
Compare
|
could you please add a job in the CI to make sure we don't regress ? |
|
There's a Mac ARM build in there already, and it's passing on main/master. So I would need to find the difference between the Mac ARM build in CI, and my Mac. I'm not sure the best way to do that. |
|
Ah - the CICD sets the And we can make CICD reproduce my failing build by removing the I don't know, it feels a bit duplicative to have to set that flag explicitly. |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, attempting to compile on Macs would bring in the SELinux dependencies (runcon) which led to compilation errors on Macs.
Fixes #7695.