Update jvm artifact deployment for new maven central portal #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 077ac88.
|
After this one is merged, we can setup the Snapshot repository as requested in #269 |
|
Good choice on VannikTech as the plugin to use, it's been my go-to for Maven Central releases for a while now and the update to the new repo was fairly painless. It's certainly much faster to release now! I also had to generate new tokens in the Sonatype web UI, the old ones would not work for me. I know some stuff has changed since the initial news that we need to migrate, and I had migrated all my projects about a month ago, so my experience may not match yours. |
piiertho
reviewed
Jun 10, 2025
| - name: Setup publish gradle properties | ||
| shell: sh | ||
| run: | | ||
| echo "mavenCentralUsername=$GODOT_KOTLIN_MAVEN_CENTRAL_PORTAL_TOKEN_USERNAME" >> ~/.gradle/gradle.properties |
There was a problem hiding this comment.
Why do we write those to properties ?
piiertho
reviewed
Jun 10, 2025
| @@ -13,10 +13,10 @@ on: | |||
| type: string | |||
|
|
|||
| env: | |||
| GODOT_KOTLIN_GPG_PRIVATE_KEY_ASCII: ${{ secrets.GODOT_KOTLIN_GPG_PRIVATE_KEY_ASCII }} | |||
| GODOT_KOTLIN_GPG_PRIVATE_KEY_ASCII: ${{ secrets.GODOT_KOTLIN_GPG_PRIVATE_KEY_ASCII_CLEANED }} # TODO: remove old key and rename this one once we're sure that the new deployment works | |||
There was a problem hiding this comment.
I would rename GODOT_KOTLIN prefix to UTOPIA_RISE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our jvm deployment plugin and ci/cd setup for the new maven central plugin portal as the old one is discontinued and we cannot publish updates anymore.
As there is no official gradle plugin yet to publish to the new plugin portal using gradle, this third party gradle plugin is used and configured instead as it's one ofe the mentioned third party alternatives in the official documentation.
Open tasks:
GODOT_KOTLIN_MAVEN_CENTRAL_PORTAL_TOKEN_PASSWORDGODOT_KOTLIN_MAVEN_CENTRAL_PORTAL_TOKEN_USERNAMEGODOT_KOTLIN_GPG_PRIVATE_KEY_ASCIIand rename and moveGODOT_KOTLIN_GPG_PRIVATE_KEY_ASCII_CLEANEDto org level