Skip to content

#247 Refactor bitbucket #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

harshithsaiv
Copy link
Contributor

Moved each Bitbucket pipeline step into its respective Tool class by:

  1. Adding a new abstract get_bitbucket_step() method to the Tool protocol
  2. Implementing this method in relevant tool classes:
    • PreCommitTool
    • RuffTool
    • DeptryTool
    • PyprojectFmtTool

Copy link
Collaborator

@nathanjmcdougall nathanjmcdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, sorry I didn't mean to approve yet.

@nathanjmcdougall nathanjmcdougall dismissed their stale review February 7, 2025 09:33

I'll take it from here

Copy link

codspeed-hq bot commented Feb 7, 2025

CodSpeed Performance Report

Merging #269 will not alter performance

Comparing harshithsaiv:247-refactor-bitbucket (d5bece4) with main (220af20)

Summary

✅ 1 untouched benchmarks

@nathanjmcdougall nathanjmcdougall merged commit 129ede5 into usethis-python:main Feb 7, 2025
15 checks passed
@nathanjmcdougall
Copy link
Collaborator

Thanks @harshithsaiv !

@nathanjmcdougall nathanjmcdougall linked an issue Feb 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Bitbucket step definitions into the Tool class
2 participants