interpolate credentialsId in the token viewer #5115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #4744 where the OAuth2 token viewer incorrectly reported "No token found" when variables were used as the Token ID in OAuth 2.0 Client Credentials configuration.
Cause
The
credentialsId
parameter was not being interpolated with collection variables before being used to find the stored credentials. This caused a mismatch between the interpolated URL and the non-interpolated credentials ID when searching for stored OAuth2 credentials.Changes Made
Added interpolation for
credentialsId
: Now properly interpolates variables in the Token ID fieldFiles Modified:
packages/bruno-app/src/components/RequestPane/Auth/OAuth2/Oauth2TokenViewer/index.js
packages/bruno-app/src/components/RequestPane/Auth/OAuth2/Oauth2ActionButtons/index.js
Testing
This fix resolves the scenario where:
{{my_credentials_id}}
)Contribution Checklist: