Fix: infinite recursion in buildEmptyJsonBody #4547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/bruno-converters/tests/openapi/openapi-circular-references.spec.js
Outdated
Show resolved
Hide resolved
maintainer-bruno
requested changes
May 15, 2025
maintainer-bruno
approved these changes
May 19, 2025
pooja-bruno
force-pushed
the
fix/infinite-recursion-in-buildEmptyJsonBody
branch
from
36978c3 to
df16ce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a issue in the OpenAPI to Bruno converter where circular references in JSON schemas would cause a "Maximum callstack size exceeded" error. Added a visited Map parameter to the
buildEmptyJsonBodyfunction to track already processed schemas and prevent infinite recursion when handling complex nested structures. This fix ensures that OpenAPI specifications with circular references can be properly imported without crashing.JIRA
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.