Nest examples by API group for building the image. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Tang <jason@upbound.io>
Signed-off-by: Jason Tang <jason@upbound.io>
jastang
requested review from
sergenyalcin,
turkenf and
ulucinar
as code owners
jeanduplessis
approved these changes
Sep 4, 2025
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes https://linear.app/upboundio/issue/EXT-30/examples-missing-from-v2-family-packages.
upCLI assumes a single filepath is recursively walked to collect example manifests. separating by scope would require walking two paths, so the less intrusive fix is to change the directory structure, which can be arbitrary as it is appended to the image as an annotated layer.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
local build + push to inspect the annotated layer for all examples.
e.g. compute