-
Notifications
You must be signed in to change notification settings - Fork 7
crossplane v2: generate namespaced MRs #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erhancagirici
merged 33 commits into
upbound:main
from
erhancagirici:crossplane-v2-upjet-v2
Aug 9, 2025
Merged
crossplane v2: generate namespaced MRs #66
erhancagirici
merged 33 commits into
upbound:main
from
erhancagirici:crossplane-v2-upjet-v2
Aug 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
190cffc
to
86b25e2
Compare
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
sergenyalcin
approved these changes
Aug 7, 2025
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
notable API updates
gcp-beta.m.crossplane.io
groupv1beta1
ProviderConfig.gcp-beta.m.crossplane.io
is now a namespaced API.ClusterProviderConfig.gcp-beta.m.crossplane.io
for new APIs to refer to a cluster-scoped provider config.spec.providerConfigRef
is now acceptskind
parameter,ProviderConfig
orClusterProviderConfig
for new MRs.spec.providerConfigRef
now defaults toClusterProviderConfig
with namedefault
when omitted.spec.writeConnectionSecretToRef
and sensitive input parameters (e.g.spec.forProvider.fooSecretRef
) for namespaced MRs are now local secret references, i.e. no namespace is supplied and same namespace with MR is assumed.spec.publishConnectionDetailsTo
is removed). This feature was alpha and it was decided to be removed from crossplane.SafeStart
capability (crossplane v2-only), which start controllers as their CRD appears.repo structure changes:
apis
,controllers
andexamples
now have scoped subdirectories ascluster
andnamespaced
Backward-compatibility with crossplane v1 environments:
provider v2 version can be installed into crossplane v1 environments, with following notes:
cluster-scoped
MRs,namespace-scoped
MR CRDs will still be installed and they cannot be composed.SafeStart
capability will be disabled.I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
manually using all examples