-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate configuration-gcp-gke to Upbound DevEx #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
Hi @ytsarev ,
I am not sure if 1 and 2 are connected. But, i was never able to stand-up my cluster. Would you please check ? |
@sivabalan19, thank you very much for testing. Can you please clarify which MRs this message belongs to and show the full |
hey @ytsarev , Like we discussed here is the
|
… update conflicts - Split resources into base_items (ServiceAccount, ServiceAccountKey) and gke_items (all GKE resources) - Only create GKE cluster after ServiceAccount is ready with email and conditions - Simplify conditional logic since GKE resources now have guaranteed service account data - Move ProjectIAMMember to conditional section as it depends on service account - Prevents immutable field update errors when service account changes from "default" Signed-off-by: Yury Tsarev <yury@upbound.io>
@sivabalan19 thanks a lot for the catch! I traced the issue and it appears to be happening when cluster is created with I solved it in fca07d3 by explicitly ordering the service account and GKE cluster resources. Full acceptance tests below:
|
Signed-off-by: Yury Tsarev <yury@upbound.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me now. e2e test went well and deployed that as a seperat project too.
Description of your changes
Key Changes:
_ocds?.resourceName?.Resource?.status?.atProvider?.field pattern
condition else {}) to avoid null values
dependencies
Migration Benefits:
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
Testing: