Accuracy, Correctness, new Python & JavaScript APIs #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash if there is an error in batch addition.
Example:
```
const usearch = require('usearch');
const index = new usearch.Index({ metric: 'l2sq', connectivity: 16, dimensions: 3 });
index.add(42n, new Float32Array([0.2, 0.6, 0.4]));
index.add(
[41n, 42n, 43n],
[[0.1, 0.6, 0.4], [0.2, 0.6, 0.4], [0.3, 0.6, 0.4]]
)
```
`42n` is duplicated, which causes an error, but then it crash.
It seems that it is not better to throw an exception during the process,
so we changed it to throw it after it is completed.
Co-authored-by: Ash Vardanian <1983160+ashvardanian@users.noreply.github.com>
Fixes a correctness bug caused by a wrong memory override. This PR adds a 3rd contant-capacity priority queue specifically for refinements. This positively affects the accuracy at a negligible memory cost. --------- Co-authored-by: Ash Vardanian <1983160+ashvardanian@users.noreply.github.com>
ashvardanian
changed the title
Errors can be set only from the main thread, so before spawning workers we need temporary space to keep the message.
abetomo
reviewed
May 15, 2025
| @@ -351,8 +354,14 @@ export class Index { | |||
| ); | |||
| } | |||
|
|
|||
| if ((!Number.isNaN(threads) && typeof threads !== "number") || threads < 0) { | |||
There was a problem hiding this comment.
Since the validation of threads is the same, it would be better to make it a method.
I will refactor it if you like.
abetomo
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "major minor" release 😅
It doesn't break anything, doesn't change too much, but will be beneficial to all users - big or small - from indie devs to larger orgs (AFAIK every major AI lab now uses USearch), and is mostly driven by the community, not by me. So thanks to everyone!
Index.restorein Python 👏