Skip to content

Conversation

@djsaunde
Copy link
Collaborator

@djsaunde djsaunde commented Oct 8, 2025

This PR adds the ruff (check and format) pre-commit hook in order to get this codebase closer to PEP 8 compliance. It also adds a GitHub action that runs on PRs / pushes to main that runs the pre-commit hooks.

This ensures any PRs that are incoming have code that is formatted properly, so we don't have to have code style discussion as part of PR review.

Note that the only "manual" changes are (1) adding the pre-commit hooks / configuration, and (2) adding the GitHub action to run the hooks; the rest of the changes come from applying the ruff pre-commit hook.

Some more complicated error codes are ignored and can be handled in future PRs.

@djsaunde djsaunde force-pushed the ruff branch 3 times, most recently from ebd7c8b to 4506e0d Compare October 9, 2025 15:36
@djsaunde
Copy link
Collaborator Author

I added scripts/enforce_kwargs_spacing.py and scripts/run_ruff_format.py to keep our custom foo = bar kwargs spacing intact. This PR should be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant