-
Notifications
You must be signed in to change notification settings - Fork 821
docs(ToDo): Add link to added toc of ToDo-App guide #19856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs(ToDo): Add link to added toc of ToDo-App guide #19856
Conversation
|
@booskander seems linke here is also nobody interested in having this even added to the toc... |
|
I'm not sure if the to-do app is up to date or not? @agneszitte |
|
@MartinZikmund looking at the list of "Issues" or better named ToDo's ;) on the Samples Repository, it would be good, if the team could check on the Related Issues and PR (not just mine, thats more meaning the ones from the others, which are more familar with its contents). But in general, it would make sense, as the PR I linked here before, would add a bit more explaination about what we are seeing, this could be already an improvement, because that would allow the Reader to understand and maybe replicate this app, just as the Maui ToDo App sample is doing 👍 |
3181459 to
963e396
Compare
…Link-to-added-toc
| href: external/uno.chefs/doc/toc.yml | ||
| topicHref: xref:Uno.Chefs.Overview | ||
| - name: ToDo-App | ||
| href: external/uno.samples/reference/todo/toc.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the CI is failing, this toc.yml doesn't seem to exist at this location in the samples repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kazo0 thats coming from the fact that the PR which I linked above should add this.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
|
@agneszitte @Jen-Uno well, since there seems to be no interest in this up from the time some months ago, where I mentioned this PR and its toc adding PR on the uno main repo, to be ready for review as part 1, as start of showing this as guide in the uno docs, as sample with some explanation, I think I will just close this PR 🤷 That was what I meant lately with the reason why I am preferring to make my Uno Sample apps Repo with the MvuxGallery and the XamlNavigationApp in my own repo. Even if I send some PR over to Uno with di s or Samples, up from the 6.0 release the chances of them being reviewed and public to the community to see and ease their learning path are almost 0% 😔 |
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Only Source link with captions, not really good to lookup for beginners
What is the new behavior?
Adding reference to the added docs of ToDo App in Samples Repository
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Related to unoplatform/Uno.Samples#875
Merge Sample before this PR to successfully build DocFx!
PR in samples is first part and first enhances and providing the structure to proceed on docs creation like by markdownlint fixes and better toc structure with code-csharp tags to enable visibility of the code without having to visit sourcecode actually
Internal Issue (If applicable):