Rework paging for all paged endpoints #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
force-pushed
the
cp/rework-paging
branch
from
0064762 to
f2c6a54
Compare
hojberg
approved these changes
May 27, 2025
hojberg
added a commit
to unisoncomputing/share-ui
that referenced
this pull request
May 27, 2025
The API (with unisoncomputing/share-api#79) now supports a previous and a next cursor. Update the API integration to match.
hojberg
added a commit
to unisoncomputing/share-ui
that referenced
this pull request
May 27, 2025
The API (with unisoncomputing/share-api#79) now supports a previous and a next cursor. Update the API integration to match.
ChrisPenner
force-pushed
the
cp/rework-paging
branch
2 times, most recently
from
e778c79 to
c19f9be
Compare
ChrisPenner
force-pushed
the
cp/rework-paging
branch
from
c19f9be to
9449750
Compare
hojberg
added a commit
to unisoncomputing/share-ui
that referenced
this pull request
Jun 3, 2025
The API (with unisoncomputing/share-api#79) now supports a previous and a next cursor. Update the API integration to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The previous paging solution didn't have any mechanism for paging backwards 😓
This adds that.
Unfortunately most of these endpoints don't currently detect when we're out of results to return a null cursor, so I should probably do another pass on that at some point; but one thing at a time.
Implementation notes
Swaps paged endpoints to return
nextCursorandpreviousCursor.Test coverage
Transcripts, but should probably test on staging at some point since it's a surprisingly tricky change to get right.