Skip to content

Improve offsets data #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

Improve offsets data #6742

merged 3 commits into from
Jul 14, 2025

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jul 10, 2025

#6238

Based on a bug in parse-zoneinfo that I fixed

Copy link

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

sffc
sffc previously approved these changes Jul 10, 2025
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and it makes the data cleaner

@robertbastian robertbastian marked this pull request as ready for review July 11, 2025 23:01
@robertbastian robertbastian requested review from Manishearth and a team as code owners July 11, 2025 23:01
@robertbastian robertbastian requested a review from sffc July 11, 2025 23:01
@robertbastian robertbastian marked this pull request as draft July 12, 2025 21:32
@robertbastian robertbastian marked this pull request as ready for review July 14, 2025 16:19
@robertbastian robertbastian merged commit d156e08 into unicode-org:main Jul 14, 2025
30 checks passed
@robertbastian robertbastian deleted the offsets branch July 14, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants