Skip to content

Refactor units provider structure by renaming modules and adding new folder for units #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

younies
Copy link
Member

@younies younies commented Jul 8, 2025

Description

  • Renamed units_essentials to units::essentials and units to units::display_names for better organization.
  • Updated references throughout the codebase to reflect the new module structure.

…folder for units (unicode-org#6734)

# Description

- Renamed `units_essentials` to `units::essentials` and `units` to `units::display_names` for better organization.
- Introduced new files for `UnitsDisplayName` and `UnitsEssentials` data structures.
- Updated references throughout the codebase to reflect the new module structure.
@younies younies requested review from sffc, robertbastian, Manishearth and a team as code owners July 8, 2025 17:13
Copy link

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

robertbastian
robertbastian previously approved these changes Jul 9, 2025
@@ -18,7 +18,7 @@ icu_provider::data_marker!(
UnitsDisplayNameV1,
UnitsDisplayName<'static>,
#[cfg(feature = "datagen")]
attributes_domain = "units"
attributes_domain = "display_names"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a global namespace, so just display_names is wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@younies younies closed this Jul 9, 2025
@younies younies reopened this Jul 9, 2025
@younies younies closed this Jul 9, 2025
@younies younies reopened this Jul 9, 2025
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR appears to be moving things around. OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants