-
Notifications
You must be signed in to change notification settings - Fork 215
Refactor units provider structure by renaming modules and adding new folder for units #6738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…folder for units (unicode-org#6734) # Description - Renamed `units_essentials` to `units::essentials` and `units` to `units::display_names` for better organization. - Introduced new files for `UnitsDisplayName` and `UnitsEssentials` data structures. - Updated references throughout the codebase to reflect the new module structure.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
@@ -18,7 +18,7 @@ icu_provider::data_marker!( | |||
UnitsDisplayNameV1, | |||
UnitsDisplayName<'static>, | |||
#[cfg(feature = "datagen")] | |||
attributes_domain = "units" | |||
attributes_domain = "display_names" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a global namespace, so just display_names
is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR appears to be moving things around. OK.
Description
units_essentials
tounits::essentials
andunits
tounits::display_names
for better organization.