Skip to content

Add TimeZoneVariant::Sundown and use it for Morocco #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

robertbastian
Copy link
Member

Copy link

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

sffc
sffc previously requested changes Jun 25, 2025
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think that we should support a display name during Ramadan time, not printing the Localized GMT, which is not user-friendly.

@robertbastian
Copy link
Member Author

This PR is not ready to be reviewed. You can leave comments on the CLDR issue

@robertbastian robertbastian force-pushed the morocco branch 10 times, most recently from 19bf014 to e3cc701 Compare July 4, 2025 13:09
@robertbastian robertbastian changed the title Don't model Morocco as standard/daylight Add TimeZoneVariant::Sundown and use it for Morocco Jul 4, 2025
@robertbastian robertbastian force-pushed the morocco branch 2 times, most recently from e8b0f7e to 4b8eb75 Compare July 7, 2025 09:23
@robertbastian robertbastian added the discuss Discuss at a future ICU4X-SC meeting label Jul 10, 2025
@robertbastian robertbastian force-pushed the morocco branch 2 times, most recently from b917e9c to 5c873f8 Compare July 21, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Discuss at a future ICU4X-SC meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants