Skip to content

Validate plugin configuration before initialization & improve fatal registration error check #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Validate plugin configuration before initialization & improve fatal registration error check #21

wants to merge 16 commits into from

Conversation

jeangovil
Copy link
Member

@jeangovil jeangovil commented Apr 11, 2025 •
edited
Loading

This PR includes:

  • Early validation of plugin configuration against their schema before initialization.
  • Fatal plugin registration error checks for vectorizer, reranker, and generative plugins.
  • Plugin config/argument schema fixes and refactors to infer types from Zod schemas.

@jeangovil jeangovil changed the title WIP: Validate plugin configuration before initialization Validate plugin configuration before initialization Apr 11, 2025
@jeangovil jeangovil force-pushed the plugin-config-validation branch from e0aeb08 to 5e3f5fa Compare April 11, 2025 11:14
jeangovil added 13 commits April 11, 2025 14:48
@jeangovil
fix(plugin-storage-local): fix config schema
139eeb8
@jeangovil
refactor(plugin-storage-local): remove redundant config validation
c0ccc49
@jeangovil
fix(plugin-img2vec-neural): require baseURL in configuration
3b4b463
@jeangovil
fix(plugin-reranker-transformers): require baseURL in configuration
603ea35
@jeangovil
fix(plugin-multi2vec-clip): require baseURL in configuration
53b33c9
@jeangovil
refactor(plugin-file-parser-image): remove unused configuration types
b038edb
@jeangovil
fix(plugin-text2vec-openai): infer config and argument types from zod…
5aeef26 
… schemas
@jeangovil
fix(plugin-enhancer-summarizer): fix arg schema and infer config and …
8c919d0 
…argument types from zod schemas
@jeangovil
refactor(plugin-enhancer-structured-output-generator): infer config a…
e9ba27a 
…nd argument types from zod schemas
@jeangovil
refactor(plugin-reranker-cohere): infer config and argument types fro…
5e4d99a 
…m zod schemas
@jeangovil
refactor(plugin-generative-openai): infer config and argument types f…
b091565 
…rom zod schemas
@jeangovil
refactor(plugin-multi2vec-cohere): infer config and argument types fr…
15a0219 
…om zod schemas
@jeangovil
refactor(plugin-text2vec-cohere): infer config and argument types fro…
3dc056a 
…m zod schemas
@jeangovil jeangovil changed the title Validate plugin configuration before initialization Validate plugin configuration before initialization & improve fatal registration error check Apr 11, 2025
@jeangovil jeangovil requested a review from krksgbr April 21, 2025 13:30
@jeangovil jeangovil marked this pull request as ready for review April 21, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krksgbr krksgbr Awaiting requested review from krksgbr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeangovil