fix(extensions): always calculate fix option
#393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bd5a7b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe test suite for the 'extensions' ESLint rule was updated by adding four new invalid test cases. These cases focus on verifying the rule's autofix behavior regarding '.js' file extensions in import statements, under various configurations of the Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant ExtensionsRule
TestRunner->>ExtensionsRule: Run with 'never' and various fix options
ExtensionsRule-->>TestRunner: Detects '.js' extension in import
alt fix enabled (default/true)
ExtensionsRule-->>TestRunner: Returns autofixed import (extension removed)
else fix false
ExtensionsRule-->>TestRunner: Returns suggestion, no autofix
end
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to d51f400 in 1 minute and 20 seconds. Click for details.
- Reviewed
78lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. test/rules/extensions.spec.ts:177
- Draft comment:
Good test: 'extensions should autofix by default' clearly checks that the autofix output is applied without an explicit fix option. Consider adding an inline comment referencing issue #391. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is purely informative, acknowledging a good test and suggesting an inline comment for reference. It doesn't provide a specific code suggestion or highlight a potential issue.
2. test/rules/extensions.spec.ts:190
- Draft comment:
The 'fix: true' test is clear and repeats the expected behavior. In future, consider consolidating similar cases to reduce duplication. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. test/rules/extensions.spec.ts:204
- Draft comment:
This test confirms that adding an empty pattern object with fix: true behaves like the basic case. The explicit nature of this test is good for future maintenance. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it describes what the test does and praises its explicit nature. It doesn't provide any actionable feedback or suggestions for improvement.
4. test/rules/extensions.spec.ts:218
- Draft comment:
The test for 'extensions should not autofix when fix is set to false' correctly checks that autofix is suppressed and suggestions are provided instead. This use of suggestions is clear and appropriate. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it simply states that the test is correct and appropriate. It does not provide any actionable feedback or suggestions for improvement.
Workflow ID: wflow_tVc2kLeFJtemCPAM
You can customize 
Follow-up to un-ts#391 These tests demonstrate that the `import-x/extensions` rule only applies autofixes when both `fix: true` and a `pattern` object are set—even if the pattern is empty. This behavior is unintuitive, undocumented, and inconsistent with how autofix typically works in ESLint. The tests assert on the `output` field to document the current (broken) behavior and provide a basis for resolving the issue. In addition to fixing the logic, I recommend removing the `fix` option entirely, as it is undocumented and not used in any other rule in the plugin.
JounQin
force-pushed
the
fix-extensions-autofix
branch
from
9c2f168 to
42b062f
Compare
JounQin
changed the title
fix option
Signed-off-by: JounQin <admin@1stg.me>
commit: |
JounQin
approved these changes
Jun 24, 2025
This was referenced Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #391
Initially, it only adds failing test cases that expose the broken autofix behavior of the
extensionsrule.Root issue
Autofix does not work unless both
fix: trueand apatternobject are set — even if the pattern is empty. This behavior is not intuitive, not documented, and not consistent with how autofix works in other ESLint rules.Suggested solution
The rule should apply autofixes by default when it is safe to do so. The
fixoption should be removed entirely.This PR starts by adding tests to document the current (broken) behavior.
Notes
extensions.spec.ts, but none of the existing tests asserted on the actualoutputfield, which is what validates whether autofixes are being applied. That gap likely contributed to this issue being missed.Important
Add failing tests in
extensions.spec.tsto expose broken autofix behavior ofextensionsrule requiring bothfix: trueand apatternobject.extensions.spec.tsto expose broken autofix behavior ofextensionsrule.fix: trueand apatternobject, even if empty, to work.fix: true,fix: truewith pattern, andfix: false.This description was created by
for d51f400. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit