fix(deps): declare missing dependencies #26

remcohaszing · 2025-07-25T09:06:51Z

The types import @typescript-eslint/utils and type-fest. These dependencies were missing from package.json.

Important

Add missing dependencies @typescript-eslint/utils and type-fest to package.json.

Dependencies:
- Add @typescript-eslint/utils version ^8.34.0 to dependencies in package.json.
- Add type-fest version ^4.39.1 to dependencies in package.json.

^{This description was created by}^{for a9b4905. You can customize this summary. It will automatically update as commits are pushed.}

Summary by CodeRabbit

Chores
- Added two new runtime dependencies: @typescript-eslint/utils and type-fest.
- No functional or public API changes; this is a low-risk maintenance update that does not alter user-visible behavior.

The types import `@typescript-eslint/utils` and `type-fest`. These dependencies were missing from `package.json`.

changeset-bot · 2025-07-25T09:06:55Z

⚠️ No Changeset found

Latest commit: 0258551

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-07-25T09:06:59Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Added two dependencies to package.json: @typescript-eslint/utils (^8.34.0) and type-fest (^4.39.1); also inserted a trailing comma after the existing stable-hash-x entry. No other changes.

Changes

Cohort / File(s)	Change Summary
Package manifest `package.json`	Added dependencies `@typescript-eslint/utils` (^8.34.0) and `type-fest` (^4.39.1); added a trailing comma after `stable-hash-x` entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

dependencies

Poem

In the package patch I hop and cheer,
Two tidy friends have come quite near.
A comma placed with perfect art,
New types to soothe the typed-heart.
🐇✨

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codesandbox-ci · 2025-07-25T09:07:18Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

ellipsis-dev

Important

Looks good to me! 👍

Reviewed everything up to a9b4905 in 1 minute and 4 seconds. Click for details.

Reviewed 16 lines of code in 1 files
Skipped 1 files when reviewing.
Skipped posting 3 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. package.json:54

Draft comment:
Added dependency '@typescript-eslint/utils'. Confirm if it should be in dependencies (runtime) or devDependencies (type-only).
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

2. package.json:57

Draft comment:
Added missing dependency 'type-fest'. Validate its placement based on how its types are used.
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

3. package.json:56

Draft comment:
Comma added to 'stable-hash-x' for valid JSON formatting. Confirm consistency with the rest of the file.
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_Z2kybVsOseDN2Z4d

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

package.json (1)
53-58: Consider moving type-fest to devDependencies.

type-fest is a type-only package; after transpilation no runtime require() call is emitted, so it will never be loaded in production. Moving it to devDependencies keeps the runtime install footprint minimal and avoids consumers of this library pulling an unnecessary package.
 "dependencies": {
   "@typescript-eslint/utils": "^8.34.0",
   "get-tsconfig": "^4.10.1",
   "stable-hash-x": "^0.2.0",
-  "type-fest": "^4.39.1"
+},
+"devDependencies": {
+  "type-fest": "^4.39.1",
(Adjust surrounding commas/indentation accordingly.)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 070e5e3 and a9b4905.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (1)

package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Socket Security: Pull Request Alerts

🔇 Additional comments (1)

package.json (1)

53-55: Double-check version compatibility between @typescript-eslint/utils and ESLint 9.

The repo now depends on eslint@^9.29.0 (dev) while @typescript-eslint/utils@^8.34.0 historically aligned with ESLint 8. Recent releases of @typescript-eslint/* may already declare compatibility with ESLint 9, but the major is still 8. Please confirm no peer-dependency warnings are produced.

If incompatibilities appear, bumping to the latest @typescript-eslint version that explicitly supports ESLint 9 will prevent runtime failures when rules use the utils package.

This is a workaround for un-ts/eslint-import-context#26.

socket-security · 2025-07-25T09:18:47Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Quality
	node-releases@2.0.19
	isarray@0.0.1 ⏵ 2.0.5	^-20
	which-collection@1.0.2
	safer-buffer@2.1.2
	is-set@2.0.3
	is-weakmap@2.0.2
	typedarray@0.0.6
	set-function-length@1.2.2
	path-parse@1.0.7
	object-keys@1.1.1
	typed-array-buffer@1.0.3
	unbox-primitive@1.1.0
	safe-regex-test@1.1.0
	is-shared-array-buffer@1.0.4
	safe-array-concat@1.1.3
	side-channel@1.1.0
	is-weakset@2.0.4
	typed-array-length@1.0.7
	string.prototype.trim@1.2.10
	object.values@1.2.1
	typed-array-byte-length@1.0.3
	which-boxed-primitive@1.1.1
	typed-array-byte-offset@1.0.4
	is-weakref@1.1.1
	is-string@1.1.1
	is-symbol@1.1.1
	is-number-object@1.1.1
	regexp.prototype.flags@1.5.4
	object.assign@4.1.7
	safe-buffer@5.2.1
	string.prototype.trimstart@1.0.8
	string.prototype.trimend@1.0.9
	which-typed-array@1.1.19
	object-assign@4.1.1
See 342 more rows in the dashboard

View full report

JounQin · 2025-08-19T04:20:37Z

Sorry I didn't notice this PR, but I'm also unusre should we mark types as dependencies or devDependencies or optionalDependencies, that's also why I'm declaring unrs-resolver as optional peerDependencies.

remcohaszing · 2025-08-21T08:56:26Z

If you intend to support TypeScript, you should make sure the types work without type errors. That means that if the imports end up in the published declaration files, they should be declared in the package dependencies.

The alternative is to not publish type definitions and leave that to DefinitelyTyped. But knowing you and considering this project is written in TypeScript, I don’t think that’s what you want.

fix(deps): declare missing dependencies

a9b4905

The types import `@typescript-eslint/utils` and `type-fest`. These dependencies were missing from `package.json`.

ellipsis-dev bot reviewed Jul 25, 2025

View reviewed changes

coderabbitai bot reviewed Jul 25, 2025

View reviewed changes

remcohaszing added a commit to remcohaszing/eslint that referenced this pull request Jul 25, 2025

Add type-fest to dev dependencies

d214c55

This is a workaround for un-ts/eslint-import-context#26.

remcohaszing added 2 commits August 21, 2025 10:57

Merge branch 'main' into missing-dependencies

83c36d4

chore: fix up yarn.lock

0258551

Uh oh!

fix(deps): declare missing dependencies #26

Are you sure you want to change the base?

fix(deps): declare missing dependencies #26

Uh oh!

Conversation

remcohaszing commented Jul 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

codesandbox-ci bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JounQin commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

remcohaszing commented Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

remcohaszing commented Jul 25, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jul 25, 2025 •

edited

Loading

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codesandbox-ci bot commented Jul 25, 2025 •

edited

Loading

socket-security bot commented Jul 25, 2025 •

edited

Loading

JounQin commented Aug 19, 2025 •

edited

Loading