COCOS-456 Remove SEV support from repo #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorcaslitunya
force-pushed
the
dorcaslitunya/cocos-456/remove-sev
branch
3 times, most recently
from
4297033 to
9bf39e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 47.47% 47.46% -0.01%
==========================================
Files 68 68
Lines 6359 6341 -18
==========================================
- Hits 3019 3010 -9
+ Misses 3025 3015 -10
- Partials 315 316 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SammyOina
requested changes
Jul 1, 2025
Contributor
SammyOina
left a comment
SammyOina
left a comment
There was a problem hiding this comment.
also look into more of the code base for specific sev conditions which are no longer needed, update readme docs as well . https://github.com/dorcaslitunya/cocos/blob/dorcaslitunya/cocos-456/remove-sev/manager/README.md https://github.com/dorcaslitunya/cocos/blob/9bf39e8e539e81c661ea6cfff831294b61453ac7/manager/qemu/vm.go#L67
these are just some examples, there should be more changes needed
dorcaslitunya
force-pushed
the
dorcaslitunya/cocos-456/remove-sev
branch
2 times, most recently
from
c95bab3 to
b942804
Compare
SammyOina
reviewed
Jul 4, 2025
dorcaslitunya
force-pushed
the
dorcaslitunya/cocos-456/remove-sev
branch
3 times, most recently
from
3f75f91 to
e68a881
Compare
dorcaslitunya
force-pushed
the
dorcaslitunya/cocos-456/remove-sev
branch
from
e68a881 to
124f97e
Compare
dorcaslitunya
force-pushed
the
dorcaslitunya/cocos-456/remove-sev
branch
3 times, most recently
from
2def763 to
c7a3ea5
Compare
dorcaslitunya
force-pushed
the
dorcaslitunya/cocos-456/remove-sev
branch
from
c7a3ea5 to
a5b5336
Compare
SammyOina
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature as it removes SEV support from cocos
What does this do?
Remove SEV support in cocos
Which issue(s) does this PR fix/relate to?
#456
Have you included tests for your changes?
No tests needed as it is removing a feature
Did you document any new/modified feature?
No, but documentation will be updated in a separate PR
Notes