Skip to content

Conversation

@FilipCivljak
Copy link
Contributor

resolves: #10

Copy link
Contributor

@SammyOina SammyOina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update readme with instructions for where to place datasets once downloaded

Copy link
Contributor

@SammyOina SammyOina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a requirements file

Copy link
Contributor

@SammyOina SammyOina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix typos in readme file, also include step by step actions to take when testing with cocos

requirements.txt Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limit to minimum requirements required for file

numpy==2.0.0
pandas==2.2.2
scikit-learn==1.5.1
torch==2.3.1
joblib==1.4.2
matplotlib==3.9.1

torch==2.3.1
joblib==1.4.2
matplotlib==3.9.1
seaborn==0.13.2 No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an empty line at the end

Copy link
Contributor

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dborovcanin
Copy link
Contributor

@FilipCivljak Please rebase and resolve comments.

Dockerfile for Fraud Detection

Renamed Dockerfiles, modified rul and covid prediction scripts, and added new Dockerfiles

Renamed inference Dockerfiles to Dockerfile.infer

Change command in Dockerfile from python3 to python

Changes on requiremnts.txt and python.yaml
Signed-off-by: filip <filipcivljak007@gmail.com>
@dborovcanin
Copy link
Contributor

@SammyOina Please review.

@drasko
Copy link
Contributor

drasko commented Sep 11, 2024

@SammyOina please review

1 similar comment
@drasko
Copy link
Contributor

drasko commented Sep 11, 2024

@SammyOina please review

Signed-off-by: filip <filipcivljak007@gmail.com>
paths:
- "covid19/**"
- "fraud-detection/**"
- "rul-turbofan"/**"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "rul-turbofan"/**"
- "rul-turbofan/**"

paths:
- "covid19/**"
- "fraud-detection/**"
- "rul-turbofan"/**"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "rul-turbofan"/**"
- "rul-turbofan/**"

Signed-off-by: filip <filipcivljak007@gmail.com>
```

```bash
unzip results.zip -d results
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close the code block


```bash
go run ./cmd/cli/main.go checksum ../ai/rul-turbofan/datasets/test_FD001.txt
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line after the code block

Signed-off-by: filip <filipcivljak007@gmail.com>
@drasko drasko merged commit cc4dbad into main Sep 23, 2024
2 checks passed
@dborovcanin dborovcanin deleted the rul-turbofan branch September 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test and adapt RUL - turbofan to current implementation of cocos with filesystems

6 participants