Skip to content

feat: add widget support for all UI libraries & install react-number-… #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 16, 2025

Conversation

mahtabhnp
Copy link
Contributor

…format

Copy link

codesandbox bot commented Feb 15, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 2:56pm
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 2:56pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview May 16, 2025 2:56pm

Copy link

codesandbox-ci bot commented Feb 15, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 130d5ce:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

@ukrbublik
Copy link
Owner

Please resolve merge conflicts

package.json Outdated
@@ -115,6 +115,9 @@
"madge": "^8.0.0",
"typescript": "~5.4.5"
},
"dependencies": {
"react-number-format": "^5.0.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add it to package.json in packagesdir, not in root package.json

@ukrbublik
Copy link
Owner

Could you please apply the styles for new input to make it look and fell more natural to corresponding UI frameworks (MUI, AntDesign, Fluent) (like same height, border style)?
Screenshot 2025-02-23 at 12 48 54
Screenshot 2025-02-23 at 12 49 09
Screenshot 2025-02-23 at 12 49 36

@mahtabhnp
Copy link
Contributor Author

mahtabhnp commented Feb 25, 2025

Hi,

I just wanted to follow up and check if the task has been code-reviewed yet. I’ve pushed the comments, and I’d appreciate it if you could let me know if you have any feedback or thoughts on the PR.
@ukrbublik

Thanks!

@ukrbublik
Copy link
Owner

ukrbublik commented Mar 1, 2025

Please keep pnpm-lock version 6. You changed it to 9 which led to failed checks. We use pnpm v8.

Also could you please revert formatting changes (like adding/removing whitespace, \n, (, ), ,) like in packages/antd/modules/config/index.jsx, packages/sandbox_next/lib/config_base.ts (probably caused by your linter or prettifier)? To keep changes clean.

Otherwise changes looks good.

If you use VSCode you can see useful commands in bottom bar like "i" (install pnpm 8 and packages), "examples" (run example app on port 3001), "lint", "test". Running "i" should fix issues with lock file
Screenshot 2025-03-01 at 14 24 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can we set thousand separator input number?
2 participants