Skip to content

The Dungeon Master #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 73 commits into from
May 23, 2024
Merged

The Dungeon Master #89

merged 73 commits into from
May 23, 2024

Conversation

EddieJ03
Copy link
Contributor

@EddieJ03 EddieJ03 commented May 9, 2024 •
edited
Loading

  • Give the Dungon Master Top Down View of Maze
    • Create DungeonMaster class that extends Creature
    • Remove ceiling & turn off gravity AND jump in servergamestate.cpp if DungeonMaster
    • Set player->physics.shared.corner in server.cpp if DungeonMaster to have a higher y-position
    • Extend and override update method in Camera to lock DungeonMaster (change pitch)
  • Bound Dungeon Master WASD Movement
  • Be able to zoom in/out (currently using keys I for in and O for out)
  • What if Dungeon Master drops and tries to reconnect? - updated SessionEntry to have a is_dm boolean
  • Add trap placement
    • Finish trap placement for ALL traps
  • Add trap selection - use hotbar like for Player items
    • Finish hotbar UI for ALL traps
  • Add max trap, trap placement cooldown, and trap expiration timer
  • Hide cursor, bring in crosshair for trap placement
  • mouse left-click to bring up crosshair, mouse right-click to hide crosshair
  • Shift to zoom in, space to zoom out
  • Send DM WASD movements to server to recalculate world coordinate

BUGS TO FIX:

  • Fix trap placement bug
  • Fix wall highlight bug

Miscellaneous Optimizations:

  • Optimize sending mouse xpos and ypos
  • Ignore unmovable objects when sending
  • Ignore spaces as empty floor creation

@EddieJ03 EddieJ03 linked an issue May 9, 2024 that may be closed by this pull request
The Dungeon Master #88
Closed
22 tasks
@EddieJ03 EddieJ03 changed the base branch from main to dev May 12, 2024 18:53
@EddieJ03 EddieJ03 marked this pull request as ready for review May 12, 2024 21:54
@EddieJ03 EddieJ03 added MVP Minimal Viable Product!!! Must have Gameplay i love gameeing labels May 13, 2024
EddieJ03 and others added 15 commits May 22, 2024 10:29
Tyler-Lentz
Tyler-Lentz approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Tyler-Lentz Tyler-Lentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled and Ran on my Nintendo Entertainment System. Nice PR!

Tyler-Lentz and others added 11 commits May 22, 2024 22:45
@Tyler-Lentz
fix wall and werror breaking windows
45dc809
@Tyler-Lentz
partial performance fixes: misc tiny optimizations & no longer place …
61d207e 
…floor under walls
@Tyler-Lentz
reenable first player dm
74d31eb
@Tyler-Lentz
Various fixes / optimizations
9349bd3 
1. Made client not render internal walls
2. Adjusted networking code to not allocate heap memory every received packet and instead use static buffer
3. Fix item inventory not rendering correctly for non-DM players
4. Cleaned up classification of "walllike" cells for deciding whether or not to create floors
@Tyler-Lentz
general cleanup & remove extraneous comments
a506896
@Tyler-Lentz
more misc fixes and touchups
a3916c8 
1. fix accidental regression on placing floors outside of the maze
2. slightly optimize render loop
@EddieJ03
fix wall color for DM, revert to one big big floor to improve perform…
17a5730 
…ance. RIP many floors
@Tyler-Lentz
Fix stupid ass networking "optimization"
934e360
@Tyler-Lentz
fix gui & add orb position display
d6f8cd7
@gilkeidar
dm wall textures
bf85969
@Tyler-Lentz
fix item drop in walls
d48153d
@Tyler-Lentz Tyler-Lentz merged commit d1fa430 into dev May 23, 2024
5 of 11 checks passed
@Tyler-Lentz Tyler-Lentz deleted the 88-the-dungeon-master branch May 23, 2024 19:16
@EddieJ03 EddieJ03 self-assigned this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyler-Lentz Tyler-Lentz Tyler-Lentz approved these changes

@gilkeidar gilkeidar Awaiting requested review from gilkeidar

@jhparkt jhparkt Awaiting requested review from jhparkt

@dmin12 dmin12 Awaiting requested review from dmin12

@atar13 atar13 Awaiting requested review from atar13

Assignees

@EddieJ03 EddieJ03

Labels
Gameplay i love gameeing Must have MVP Minimal Viable Product!!!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Dungeon Master
3 participants
@EddieJ03 @Tyler-Lentz @gilkeidar