-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor/client callbacks #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Also adds documentation for all methods.
… refactor/client_callbacks
…ed some variables in client to member
Tyler-Lentz
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like all these changes, thanks for grinding these out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the client class to streamline structure & logic.
Previously, the client class had static callback functions, which referenced static flags and variables. These static methods and variables were converted into member variables of
Client
. As a workaround for GLFWwindow requiring static function callbacks, all of the member callback functions are bound to a lambda, which essentially just wraps around theClient
callback functions. These lambdas reference a GLFW user pointer throughglfwGetWindowUserPointer(window)
, and this user pointer is bound to an instance ofClient
.Client::idleCallback()
was refactored by removing the call toClient::handleKeys()
, instead moving that logic to theClient::keyCallback()
. The proposed structure for input handling is as follows: for inputs that are continuous (i.e. movement, jumping),keyCallback()
will set a flag, which is separately handled inidleCallback()
, and for inputs that are press/release or single press (i.e. left shift for sprint), the event is sent directly in thekeyCallback()
, which avoids using flags for checking if events were already sent.Also fixed some bugs with camera movement logic and added a simple window resize callback.
Added documentation for
client.hpp
andcamera.hpp
.