Skip to content

Final Cleanup #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 9, 2024
Merged

Final Cleanup #219

merged 8 commits into from
Jun 9, 2024

Conversation

Tyler-Lentz
Copy link
Contributor

@Tyler-Lentz Tyler-Lentz commented Jun 9, 2024 •
edited
Loading

  • remove unused config file options & move around options to make more sense (i.e. just have client and server options)
  • make the executable work so that it is placed in the root of the repo, so that when we make a downloadable version people don't have to go into build/bin to run it
  • add screenshots to README
  • actually make the binaries to post
  • check that the binaries work
  • put link to binary download on readme

@Tyler-Lentz Tyler-Lentz marked this pull request as ready for review June 9, 2024 06:04
@atar13 atar13 self-requested a review June 9, 2024 06:06
atar13
atar13 approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@atar13 atar13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README with the logo and screenshots looks amazing. ty for putting this together

@Tyler-Lentz Tyler-Lentz merged commit 891441e into main Jun 9, 2024
11 checks passed
@Tyler-Lentz Tyler-Lentz deleted the cleanup branch June 9, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atar13 atar13 atar13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyler-Lentz @atar13