Skip to content

Make timezone parsing more portable and robust #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

jonasbardino
Copy link
Contributor

Make timezone parsing in generateconfs more portable and robust to make it work even inside docker and similar sparse envs where timedatectl is not available.
Tries TZ environment, /etc/localtime symlink to zone file and existing timedatectl command in turn.

Fixes issue with make PY=2 test spewing errors because docker doesn't have timedatectl included.

…nside

docker and similar sparse envs where timedatectl is not available.
Copy link
Contributor

@albu-diku albu-diku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albu-diku albu-diku self-requested a review July 15, 2024 12:42
Copy link
Contributor

@albu-diku albu-diku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearing my request for change now this is a function

@jonasbardino
Copy link
Contributor Author

Reviewed and merged through svn now. Thanks for the contribution and clean up @albu-diku

@albu-diku albu-diku deleted the adjust/generateconfs-robust-timezone branch July 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants