Skip to content

Adjust/generateconfs auto user group home #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jonasbardino
Copy link
Contributor

A follow-up to PR72 to switch more generateconfs arguments over to keyword_auto with dynamic expansion of user/group and related paths to fit the active environment. This is particularly useful for local development where neither the mig user nor the code and state dirs can be expected to be in the root of the home directory. It additionally allows elimination of the dynamic expansion of values in mig.shared.defaults and keeps it local to the install helpers.

@jonasbardino jonasbardino added enhancement New feature or request unit test labels Jul 1, 2024
@jonasbardino jonasbardino self-assigned this Jul 1, 2024
@jonasbardino jonasbardino marked this pull request as draft July 1, 2024 18:49
@jonasbardino jonasbardino marked this pull request as ready for review July 3, 2024 12:07
@jonasbardino jonasbardino requested a review from albu-diku July 3, 2024 12:07
@jonasbardino jonasbardino force-pushed the adjust/generateconfs-auto-user-group-home branch from 55f2132 to e3075d2 Compare July 10, 2024 06:46
…reater

flexibility on non-deployment setups and in order to eliminate the dynamic
values from PR72 in mig.shared.defaults .

Please note that this is a manual rebase of the changes originally implemented
on July 1st to 3rd, which got really messy when merging edge updates.
… and

update the fixture files accordingly.

Please note that this is a manual rebase of the changes originally implemented
on July 1st to 3rd, which got really messy when merging edge updates
@jonasbardino jonasbardino force-pushed the adjust/generateconfs-auto-user-group-home branch from f048d4d to 5dcb788 Compare July 10, 2024 07:41
@jonasbardino
Copy link
Contributor Author

Manually rebased to current edge with force push because the commit history got really messy after merging recent updates there.

@albu-diku
Copy link
Contributor

Between the CWD related hardening done in #89 and the changes that were needed to get local configs reliably written in support of the work in #77, it ended up that removal of those defaults was basically already arranged.

I pulled in the changes you made here to mig_user/mig_group into PR 77 and think that effectively subsumes this PR. Result here: https://github.com/ucphhpc/migrid-sync/pull/77/files#diff-13b2a8d0b68628063fa8692dfa94986a499e335369a21e9234a9ebd1923ddc1dL80

@jonasbardino
Copy link
Contributor Author

Yes and no, I commented on PR77 now to point out a couple of details from this PR75, which it doesn't seem to handle. If we agree I'll retire this PR and merge PR77 with those adjustments.

@jonasbardino
Copy link
Contributor Author

Folded into PR77 - retiring.

@albu-diku albu-diku deleted the adjust/generateconfs-auto-user-group-home branch August 19, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants