Make the recently added compat module standalone. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work since the introduction of ensure_native_string() has shown that being able to make use the function is limited by its inclusion of the base package. Allow the function to be used everywhere by using only the Python standard library for its operation. This sidesteps any potential for circular imports and ensures well tested string conversion is available for the _definition_ of e.g. base itself.
albu-diku
force-pushed
the
fix/no-dependency-compat
branch
from
e252e6d to
829975d
Compare
|
Thanks @albu-diku. Merged through svn with minor adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work since the introduction of ensure_native_string() has shown that being able to make use the function is limited by its inclusion of the base package. Allow the function to be used everywhere by using only the Python standard library for its operation.
This sidesteps any potential for circular imports and ensures well tested string conversion is available for the definition of e.g. base itself.