Skip to content

Conversation

jonasbardino
Copy link
Contributor

WiP to address a few old lint errors triggered by PR #359 but caused elsewhere.

@jonasbardino jonasbardino added the bug Something isn't working label Oct 13, 2025
`E1111: Assigning result of a function call, where the function has no return (assignment-from-no-return)`
`E0606: Possibly using variable 'email' before assignment (possibly-used-before-assignment)`
by bailing out with ValueError if unexpected `auth_type` was hit.
`E0606: Possibly using variable 'last_res' before assignment (possibly-used-before-assignment)`
by moving init up above conditional.
@jonasbardino jonasbardino marked this pull request as ready for review October 13, 2025 11:01
@jonasbardino jonasbardino changed the title WiP to address a few old lint errors triggered by PR #359 but caused elsewhere Address a few old lint errors triggered by PR #359 but caused elsewhere Oct 13, 2025
@jonasbardino jonasbardino self-assigned this Oct 13, 2025
@jonasbardino jonasbardino requested a review from a team October 13, 2025 11:01
@jonasbardino jonasbardino added refactor Non-functional changes to simplify or clean up and removed bug Something isn't working labels Oct 13, 2025
@jonasbardino jonasbardino merged commit d5b2230 into next Oct 13, 2025
8 of 9 checks passed
@jonasbardino jonasbardino deleted the fix/old-mrslparser-and-autocreate-lint-errors branch October 13, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Non-functional changes to simplify or clean up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants