Improved coverage and fixed string checks for basic functionality of several of the pwcrypto helpers #362
+395
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rypto helper functions as suggested by @albu-diku in the comments to PR343. Some of the tests require adjustment of the helper functions to expose the random seed as argument, so they have been left disabled for now.
jonasbardino
added
the
test-only
…lf-tests, like it's the case e.g. for `userio`, and integrate running it in unit testing. Added a lot of unit tests to cover almost all functions in `pwcrypto` and to include more tests of fundamental functionality against fixed known values as suggested in PR343 discussion. A few tests will require API changes to pass a random seed to allow that and have been left as disabled for now with TODO comments added.
jonasbardino
changed the title
…and latest stable py3. I can't see why `site_password_legacy_policy` is any different from e.g. `site_password_policy`, which does NOT trigger the same pylint error :-s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly improve test coverage and add fixed string checks for basic functionality of several of the
pwcryptohelper functions as suggested by @albu-diku in the comments to PR #343 .Some of the new tests require adjustment of the helper functions to expose the random seed as argument, so they have been left disabled with TODO markers for now.