Skip to content

Rewrite the only FancyURLopener to sidestep its deprecation. #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

Rewrite the only FancyURLopener to sidestep its deprecation. #360

merged 1 commit into from
Oct 10, 2025

Conversation

albu-diku
Copy link
Contributor

No description provided.

@albu-diku albu-diku force-pushed the refactor/address-FanURLopener-use branch 2 times, most recently from dd14131 to 5bf2448 Compare October 10, 2025 09:58
@jonasbardino jonasbardino linked an issue Oct 10, 2025 that may be closed by this pull request
Replace deprecated/removed FancyURLOpener calls in mig.shared.url module #353
Closed
@jonasbardino jonasbardino added the refactor Non-functional changes to simplify or clean up label Oct 10, 2025
jonasbardino
jonasbardino reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@jonasbardino jonasbardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend importing and using urlopen from mig.shared.url instead of adding the urllib.request import.

@albu-diku albu-diku force-pushed the refactor/address-FanURLopener-use branch from 5bf2448 to 4cfa86d Compare October 10, 2025 11:34
jonasbardino
jonasbardino approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@jonasbardino jonasbardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's get this one resolved to reduce the CI noise.

@jonasbardino jonasbardino merged commit 2f70f9c into next Oct 10, 2025
7 checks passed
@jonasbardino jonasbardino deleted the refactor/address-FanURLopener-use branch October 10, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasbardino jonasbardino jonasbardino approved these changes

Assignees

No one assigned

Labels

refactor Non-functional changes to simplify or clean up

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace deprecated/removed FancyURLOpener calls in mig.shared.url module

2 participants

@albu-diku @jonasbardino