Add recurring handling of user, resource and vgrid map refresh to janitor #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbardino
added this to the
Janitor service to handle vgrid cache updates and clean up, including pruning of account requests milestone
|
Currently fails CI due to the unrelated #353. |
|
Fundamentally verified in practice on a test site instance, but could use some more testing. |
Martin-Rehr
reviewed
Oct 9, 2025
Thanks for reviewing. If you mean keep |
jonasbardino
force-pushed
the
adjust/janitor-to-handle-all-cache-map-maintenance
branch
from
b9c4e7a to
b4c782a
Compare
…itor. Still pending removal of client initiated refresh triggers in vgridman backend.
…nd resman backends if janitor is enabled since it takes care of all refresh handling.
jonasbardino
force-pushed
the
adjust/janitor-to-handle-all-cache-map-maintenance
branch
from
b4c782a to
c892ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recurring handling of user, resource and vgrid map refresh to janitor service. Effectively centralizes the updates in a single long-running process rather than the fragile concurrent client-initiated refreshes, since they tend to result in clients hammering the site during refresh and may leave cache inconsistent if client hits HTTP time-out in the middle of a refresh (#121).
Runs in the main thread so far, but we may need to consider a background thread/process for the refresh if it turns out to delay other janitor tasks too much.
Removes client-initiated refresh triggers in
vgridmanandresmanbackends if janitor is enabled.Could perhaps use improved user-facing information e.g. about when the current (cached) view was generated on
vgridmanandresmanpages to help clarify when any recent changes are not yet fully processed and showing.