Skip to content

Conversation

jonasbardino
Copy link
Contributor

Fix some oddly embedded byte-string markers inside the pickled MiG-users.db fixture strings as they otherwise interfere with the unit tests of PR347.

…ers.db

fixture strings as they otherwise interfere with the unit tests of PR347.
@jonasbardino jonasbardino self-assigned this Oct 8, 2025
@jonasbardino jonasbardino added bug Something isn't working test-only Improvements or additions solely for better test coverage - without functionality changes labels Oct 8, 2025
@jonasbardino jonasbardino requested a review from albu-diku October 8, 2025 14:25
@jonasbardino
Copy link
Contributor Author

Not sure if it is related to the issue you raised on our chat discussion earlier today @albu-diku and perhaps it will even go away with your ongoing efforts in #349 . So I requested your review explicitly here mostly to inform you that there is/was something funny going on with that MiG-users.db fixture.

@jonasbardino jonasbardino marked this pull request as ready for review October 8, 2025 14:29
@jonasbardino
Copy link
Contributor Author

Currently fails CI due to the unrelated #353.

@jonasbardino jonasbardino merged commit ec5e11b into next Oct 8, 2025
18 of 20 checks passed
@jonasbardino jonasbardino deleted the fix/broken-encoding-in-MiG-user-db-fixture branch October 8, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test-only Improvements or additions solely for better test coverage - without functionality changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant