Support the text argument to our subprocess helpers
#293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conversion of the default utf8-encoded bytes output to native strings. Follow-up to issue #288.
This was referenced Jul 22, 2025
…he new `text` arg in particular. Use the `pwd` command for testing assuming that it's portable across all sane platforms.
|
I believe this allows a fix for #288 more in line with what we discussed on chat @albu-diku . I'll merge to get it through to the other places where it's needed (#289, #291, #292, ...), but would still like review feedback if anyone has time. |
jonasbardino
deleted the
add/support-for-passing-text-arg-to-subprocess-helpers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the
textargument to our subprocess helpers in order to ease conversion of the default utf8-encoded bytes output to native strings.Adds basic unit tests for the
mig.shared.safeevalmodule and in particular the addedtextargument.Follow-up to issue #288.